Skip to content

gh-87888: Make FileCookieJar use ASCII/surrogateescape #92392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-87888: Make FileCookieJar use ASCII/surrogateescape #92392

wants to merge 5 commits into from

Conversation

@methane
Copy link
Member

@methane methane commented May 6, 2022

  • Byte transparent reading and writing.
  • Consistent with WSGI.
  • Avoid UnicodeDecodeError when reading comments.

gh-87888

@methane
pythongh-87888: Make FileCookieJar use latin-1 instead of locale enco…
8936f8a 
…ding

* Byte transparent reading and writing.
* Consistent with WSGI.
* Avoid UnicodeDecodeError when reading comments.
@methane methane changed the title Make FileCookieJar use latin-1 instead of locale encoding gh-87888: Make FileCookieJar use latin-1 instead of locale encoding May 6, 2022
iritkatriel
iritkatriel requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict now. Is this still needed?

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

@bedevere-app bedevere-app bot mentioned this pull request Oct 23, 2024
Open
@methane methane changed the title gh-87888: Make FileCookieJar use latin-1 instead of locale encoding gh-87888: Make FileCookieJar use ASCII/surrogateescape Oct 23, 2024
@methane
Copy link
Member Author

methane commented Oct 23, 2024

I changed to use ASCII/surrogateescape instead of latin-1.
ref: https://discuss.python.org/t/using-utf-8-for-cookie-txt/15562/12

@methane methane requested a review from iritkatriel October 23, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@sobolevn sobolevn Awaiting requested review from sobolevn

@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@methane @bedevere-bot @iritkatriel